Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12005 move ensemble grid in project tree #12014

Merged
merged 4 commits into from
Dec 23, 2024
Merged

12005 move ensemble grid in project tree #12014

merged 4 commits into from
Dec 23, 2024

Conversation

kriben
Copy link
Collaborator

@kriben kriben commented Dec 20, 2024

Fixes #12005.

@kriben kriben marked this pull request as ready for review December 20, 2024 12:25
@kriben kriben requested a review from magnesj December 20, 2024 12:25
@magnesj
Make sure cached data is computed
13dac37 
Without this, the bounding box of the case is undefined, causing the polygons lines not to be visible.
magnesj
magnesj requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove RifReaderRegularGridModel, as the pattern with a file reader object is not required in this setting.

@kriben kriben merged commit 1cdbffb into dev Dec 23, 2024
17 checks passed
@kriben kriben deleted the 12005-move-ensemble-grid-in-project-tree branch December 23, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnesj magnesj magnesj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Well Target Candidates: Move ensemble grid under generator in Project Tree
2 participants
@kriben @magnesj